<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none"><!--P{margin-top:0;margin-bottom:0;} p
{margin-top:0;
margin-bottom:0}--></style>
</head>
<body dir="ltr" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;">
<p>Sounds good. My only point in having it as an external repository was to not pollute the rust-vmm with crates that we might decide are not needed. But then we can also just remove them if we decide that rust-vmm is not the place for them.</p>
<p><br>
</p>
<p>Andreea<br>
</p>
<div dir="ltr" style="text-align:left; direction:ltr">
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> Boeuf, Sebastien <sebastien.boeuf@intel.com><br>
<b>Sent:</b> Friday, February 8, 2019 9:27 PM<br>
<b>To:</b> liuj97@gmail.com; Ortiz, Samuel; Florescu, Andreea; Iordache, Alexandra; rust-vmm@lists.opendev.org; dgilbert@redhat.com; dgreid@chromium.org<br>
<b>Subject:</b> Re: [Rust-VMM] RFC:</font>
<div> </div>
</div>
<div>
<div>I agree Andreea, and I would also suggest that once we agreed on the creation of a crate, and once we agreed on the global code coming from the private repo, we still need to create a clean repo under rust-vmm and start from scratch with proper PRs that
can be reviewed.</div>
<div><br>
</div>
<div>Starting with already something in the repo sounds wrong to me. The most intensive code reviews should really happen on the rust-vmm repos.</div>
<div><br>
</div>
<div>Does that make sense?</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Sebastien</div>
<div><br>
</div>
<div>On Fri, 2019-02-08 at 11:58 +0000, Florescu, Andreea wrote:</div>
<blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid; padding-left:1ex">
<p>Hey,</p>
<p><br>
</p>
<p>For future crates I would suggest we do not create repositories directly in the rust-vmm organization and use the review process we discussed a while back:</p>
<p>- Create a repository on the personal profile</p>
<p>- Request reviews for the repository using the issue template for reviews<br>
</p>
<p><br>
</p>
<p>This process is also described in the community readme: <a href="https://github.com/rust-vmm/community">
https://github.com/rust-vmm/community</a></p>
<p><br>
</p>
<p>Regarding the review, I might be able to look at the changes somewhere after Wednesday next week.</p>
<p><br>
</p>
<p>Regards,<br>
</p>
<p>Andreea<br>
</p>
<p><br>
</p>
<div style="word-wrap:break-word; line-break:after-white-space">
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> Liu Jiang <liuj97@gmail.com><br>
<b>Sent:</b> Friday, February 8, 2019 12:17 PM<br>
<b>To:</b> rust-vmm ML; Florescu, Andreea; Samuel Ortiz; Boeuf, Sebastien; Iordache, Alexandra; Dylan Reid; Dr. David Alan Gilbert<br>
<b>Subject:</b> [Rust-VMM] RFC:</font>
<div> </div>
</div>
<div>
<div class="" style="word-wrap:break-word; line-break:after-white-space">
<div class="" style="word-wrap:break-word; line-break:after-white-space">Hi all,
<div class="">As we have discussed during the meeting, I have created a memory-model repository under rust-vmm project and posted the initial version at <a href="https://github.com/rust-vmm/memory-model" class="">https://github.com/rust-vmm/memory-model</a> .</div>
<div class="">The initial version tries to merge current code from the upstream crosvm and firecracker projects. And the most sensitive user visible change is changing from u64 to usize for memory related data fields.</div>
<div class="">So please help to comment on whether this is the right way to go, and next step plan is:</div>
<div class="">1) import <a href="http://endian.rs/" class="">endian.rs</a> from crosvm</div>
<div class="">2) add address space abstraction for virtual machine</div>
<div class="">Thanks,</div>
<div class="">Gerry</div>
</div>
</div>
</div>
</div>
<p></p>
<p><br>
Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.</p>
</blockquote>
</div>
</div>
<p></p>
<p><br>
Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.</p>
</body>
</html>