<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none"><!--P{margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;">
<p>Hey,</p>
<p><br>
</p>
<p>It's not a big deal. We can review it from rust-vmm since it is already there. I would say not to publish it as a crate yet.<br>
</p>
<p><br>
</p>
<p>When migrating the repository (even if it's private) all discussions should also be migrated by default.</p>
<p><br>
</p>
<p>Andreea<br>
</p>
<p><br>
</p>
<div style="word-wrap:break-word; line-break:after-white-space">
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> Liu Jiang <liuj97@gmail.com><br>
<b>Sent:</b> Friday, February 8, 2019 2:45 PM<br>
<b>To:</b> Florescu, Andreea<br>
<b>Cc:</b> rust-vmm ML; Samuel Ortiz; Boeuf, Sebastien; Iordache, Alexandra; Dylan Reid; Dr. David Alan Gilbert<br>
<b>Subject:</b> Re: [Rust-VMM] RFC:</font>
<div> </div>
</div>
<div>
<div class="" style="word-wrap:break-word; line-break:after-white-space">Hey,
<div class=""><span class="Apple-tab-span" style="white-space:pre"></span>Sorry for break the process. Should I delete the repository from the rust-vmm project?</div>
<div class=""><span class="Apple-tab-span" style="white-space:pre"></span>BTW, there may be some discussion threads when holding the library on private repository, so what’s the best practice to preserve discussions on private repository when migrating from
private repository to the rust-vmm project?</div>
<div class="">Thanks,</div>
<div class="">Gerry</div>
<div class="">
<div class=""><br class="">
<blockquote type="cite" class="">
<div class="">On Feb 8, 2019, at 7:58 PM, Florescu, Andreea <<a href="mailto:fandree@amazon.com" class="">fandree@amazon.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div class="" style="margin-top:0px; margin-bottom:0px; font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255); text-decoration:none">
Hey,</div>
<div class="" style="margin-top:0px; margin-bottom:0px; font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255); text-decoration:none">
<br class="">
</div>
<div class="" style="margin-top:0px; margin-bottom:0px; font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255); text-decoration:none">
For future crates I would suggest we do not create repositories directly in the rust-vmm organization and use the review process we discussed a while back:</div>
<div class="" style="margin-top:0px; margin-bottom:0px; font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255); text-decoration:none">
- Create a repository on the personal profile</div>
<div class="" style="margin-top:0px; margin-bottom:0px; font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255); text-decoration:none">
- Request reviews for the repository using the issue template for reviews<br class="">
</div>
<div class="" style="margin-top:0px; margin-bottom:0px; font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255); text-decoration:none">
<br class="">
</div>
<div class="" style="margin-top:0px; margin-bottom:0px; font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255); text-decoration:none">
This process is also described in the community readme:<span class="Apple-converted-space"> </span><a href="https://github.com/rust-vmm/community" class="">https://github.com/rust-vmm/community</a></div>
<div class="" style="margin-top:0px; margin-bottom:0px; font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255); text-decoration:none">
<br class="">
</div>
<div class="" style="margin-top:0px; margin-bottom:0px; font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255); text-decoration:none">
Regarding the review, I might be able to look at the changes somewhere after Wednesday next week.</div>
<div class="" style="margin-top:0px; margin-bottom:0px; font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255); text-decoration:none">
<br class="">
</div>
<div class="" style="margin-top:0px; margin-bottom:0px; font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255); text-decoration:none">
Regards,<br class="">
</div>
<div class="" style="margin-top:0px; margin-bottom:0px; font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255); text-decoration:none">
Andreea<br class="">
</div>
<div class="" style="margin-top:0px; margin-bottom:0px; font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255); text-decoration:none">
<br class="">
</div>
<div class="" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255); text-decoration:none; word-wrap:break-word; line-break:after-white-space">
<hr tabindex="-1" class="" style="display:inline-block; width:894.734375px">
<div id="divRplyFwdMsg" dir="ltr" class=""><font class="" style="font-size:11pt" face="Calibri, sans-serif"><b class="">From:</b><span class="Apple-converted-space"> </span>Liu Jiang <<a href="mailto:liuj97@gmail.com" class="">liuj97@gmail.com</a>><br class="">
<b class="">Sent:</b><span class="Apple-converted-space"> </span>Friday, February 8, 2019 12:17 PM<br class="">
<b class="">To:</b><span class="Apple-converted-space"> </span>rust-vmm ML; Florescu, Andreea; Samuel Ortiz; Boeuf, Sebastien; Iordache, Alexandra; Dylan Reid; Dr. David Alan Gilbert<br class="">
<b class="">Subject:</b><span class="Apple-converted-space"> </span>[Rust-VMM] RFC:</font>
<div class=""> </div>
</div>
<div class="">
<div class="" style="word-wrap:break-word; line-break:after-white-space">
<div class="" style="word-wrap:break-word; line-break:after-white-space">Hi all,
<div class=""><span class="Apple-tab-span" style="white-space:pre"></span>As we have discussed during the meeting, I have created a memory-model repository under rust-vmm project and posted the initial version at <a href="https://github.com/rust-vmm/memory-model" class="">https://github.com/rust-vmm/memory-model</a> .</div>
<div class="">The initial version tries to merge current code from the upstream crosvm and firecracker projects. And the most sensitive user visible change is changing from u64 to usize for memory related data fields.</div>
<div class="">So please help to comment on whether this is the right way to go, and next step plan is:</div>
<div class="">1) import<span class="Apple-converted-space"> </span><a href="http://endian.rs/" class="">endian.rs</a> from crosvm</div>
<div class="">2) add address space abstraction for virtual machine</div>
<div class="">Thanks,</div>
<div class="">Gerry</div>
</div>
</div>
</div>
</div>
<p class="" style="margin-top:0px; margin-bottom:0px; font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255); text-decoration:none">
</p>
<div class="" style="margin-top:0px; margin-bottom:0px; font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255); text-decoration:none">
<br class="">
Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</div>
</div>
</div>
<p></p>
<p><br>
Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.</p>
</body>
</html>