Hey Allison,
> How interested would you be in patches for Unix family operating systems
> other than Linux?
I think it makes sense to support other Unix families. We just have to
make sure we keep a clean separation and general tidiness in the
code while adding support for other platforms/OSes/stuff. This can
be discussed during code review.
> As a concrete example of how non-disruptive this can be, the patch I'm
> debating whether to submit is a 4 line substitution in vmm-sys-util,
> which changes [#cfg(unix)] to [#cfg(linux)]. Right now, those lines are
> checking for target_family = "unix", but the code in question is
> actually unique to Linux, and fails to compile on other Unix family
> operating systems (mostly due to type errors, and using features that
> only exist on Linux), so it really should be checking target_os =
> "linux" instead.
This sounds like a bug in vmm-sys-util to me. If the code only works on
Linux, it should be labeled as such. I don't see any problem in changing
it from Unix to Linux.
> src/errno.rs testing a very specific string message as the text for
> libc::EBADF, which has slightly different wording on other Unix family
> operating systems.
I don't think Display should be tested at all because this particular
implementation of Display relies on `io::Error` implementation of
Display. We're just basically forwarding the implementation. We can
either delete the Display implementation (which would make me very
happy :)) ) or use some other errors where the wording is the same
(are there any errors like that?).
I look forward to your PRs.
Andreea