Hello Fellow OpenStack and OpenDev Folks!
TL;DR click on [3] and enjoy.
I am starting this thread to not hijack the discussion happening on [1].
First of all, I would like to thank gibi (Balazs Gibizer) for hacking
a way to get the place to render the table in the first place (pun
intended).
I have been a long-time-now user of [2].
I have improved and customised it for myself but never really got to
share back the changes I made.
The new Gerrit obviously broke the whole script so it was of no use to
share at that particular state.
However, inspired by gibi's work, I decided to finally sit down and
fix it to work with Gerrit 3 and here it comes: [3].
Works well on Chrome with Tampermonkey. Not tested others.
I hope you will enjoy this little helper (I do).
I know the script looks super fugly but it generally boils down to a
mix of styles of 3 people and Gerrit having funky UI rendering.
Finally, I'd also like to thank hrw (Marcin Juszkiewicz) for linking
me to the original Michel's script in 2019.
[1] http://lists.openstack.org/pipermail/openstack-discuss/2020-November/019051…
[2] https://opendev.org/x/coats/src/commit/444c95738677593dcfed0cfd9667d4c4f0d5…
[3] https://gist.github.com/yoctozepto/7ea1271c299d143388b7c1b1802ee75e
Kind regards,
-yoctozepto
We will meet with this agenda March 30, 2021 in #opendev at 19:00UTC:
== Agenda for next meeting ==
* Announcements
* Actions from last meeting
* Specs approval
* Priority Efforts (Standing meeting agenda items. Please expand if you have subtopics.)
** [http://specs.openstack.org/openstack-infra/infra-specs/specs/update-config-… Update Config Management]
*** topic:update-cfg-mgmt
*** Zuul as CD engine
** OpenDev
*** Gerrit account inconsistencies
**** https://etherpad.opendev.org/p/gerrit-user-consistency-2021 High level notes.
**** All preferred emails lack external ids issues have been corrected. All group loops have been corrected.
**** Workaround is we can stop Gerrit, push to external ids directly, reindex accounts (and groups?), start gerrit, then clear accounts caches (and groups caches?)
**** Next steps
***** Review groups in review:~clarkb/gerrit_user_cleanups/notes.20210315 and determine if they can be safely cleaned up like previous groups.
***** https://review.opendev.org/c/opendev/system-config/+/780663 more user auditing improvements.
*** Configuration tuning
**** Using strong refs for jgit caches
**** Batch user groups and threads
* General topics
** Picking up steam on Puppet -> Ansible rewrites (clarkb 20210330)
*** Enable Xenial -> Bionic/Focal system upgrades
*** https://etherpad.opendev.org/p/infra-puppet-conversions-and-xenial-upgrades Start capturing TODO list here
*** Zuul service host updates in progress now. Scheduler and Zookeeper cluster remaining. Will focus on ZK first.
** Deploy a new refstack.openstack.org server (ianw 20210330)
*** https://review.opendev.org/c/opendev/system-config/+/781593
** PTG Planning (ianw 20210330)
*** Next PTG April 19-23
*** Clarkb filled out the survey and requested a few hours for us. Likely to be spent in more office hours type setup.
**** Thursday April 22 1400-1600UTC and 2200-0000UTC
** docs-old volume cleanup (ianw 20210330)
*** anyone think this is necessary?
*** docs-dev?
** planet.openstack.org (ianw 20210330)
*** there is no maintained aggregators any more
*** stick current venus/planet in a python 2.7 container and forget about it
*** retire it
** tarballs ORD replication (ianw 20210330)
*** only things across regions are docs & airship
*** tarballs is probably the only other thing worth having a out-of-region copy for
*** https://etherpad.opendev.org/p/gjzssFmxw48Nn3_SBVo6
* Open discussion
Hello,
As part of ongoing service upgrades, we are proposing the retirement
of the Asterisk-based SIP/voice conferencing tool [1].
The meetpad instance at https://meetpad.opendev.org/ has proven
popular for recent events and provides better services for
collaborative meetings.
Please reach out if this service is important to you. If it is
something you would like to maintain, it will require porting to our
current Ansible and container-based infrastructure (there will be
plenty of admins happy to help guide you). Otherwise we'll propose
changes to remove the configuration soon.
Thanks,
-i
[1] https://docs.opendev.org/opendev/system-config/latest/asterisk.html
We will meet on March 16, 2021 at 19:00 UTC in #opendev-meeting with this agenda:
== Agenda for next meeting ==
* Announcements
* Actions from last meeting
* Specs approval
* Priority Efforts (Standing meeting agenda items. Please expand if you have subtopics.)
** [http://specs.openstack.org/openstack-infra/infra-specs/specs/update-config-… Update Config Management]
*** topic:update-cfg-mgmt
*** Zuul as CD engine
** OpenDev
*** Gerrit account inconsistencies
**** https://etherpad.opendev.org/p/gerrit-user-consistency-2021 High level notes.
**** All preferred emails lack external ids issues have been corrected. All group loops have been corrected.
**** Workaround is we can stop Gerrit, push to external ids directly, reindex accounts (and groups?), start gerrit, then clear accounts caches (and groups caches?)
**** Next steps
***** Review groups in review:~clarkb/gerrit_user_cleanups/notes.20210315 and determine if they can be safely cleaned up like previous groups.
***** https://review.opendev.org/c/opendev/system-config/+/780663 more user auditing improvements.
*** Configuration tuning
**** Using strong refs for jgit caches
**** Batch user groups and threads
* General topics
** Picking up steam on Puppet -> Ansible rewrites (clarkb 20210316)
*** Enable Xenial -> Bionic/Focal system upgrades
*** https://etherpad.opendev.org/p/infra-puppet-conversions-and-xenial-upgrades Start capturing TODO list here
*** Zuul service host updates in progress now. Mergers, executors and launchers done. Only remaining is scheduler?
** Deploy a new refstack.openstack.org server (ianw 20210323)
*** https://review.opendev.org/c/opendev/system-config/+/781593
** PTG Planning (ianw 20210323)
*** Next PTG April 19-23
*** Please let me know if you are interested so I can fill out the team survey (or not).
* Open discussion
We will meet on March 16, 2021 at 19:00 UTC (note DST changes if you live in North America) in #opendev-meeting with this agenda:
== Agenda for next meeting ==
* Announcements
** Clarkb out March 23. Ianw has volunteered to chair the meeting on the 23rd.
** DST change has happened in North America. EU and others follow in a few weeks.
* Actions from last meeting
* Specs approval
* Priority Efforts (Standing meeting agenda items. Please expand if you have subtopics.)
** [http://specs.openstack.org/openstack-infra/infra-specs/specs/update-config-… Update Config Management]
*** topic:update-cfg-mgmt
*** Zuul as CD engine
** OpenDev
*** Gerrit account inconsistencies
**** https://etherpad.opendev.org/p/gerrit-user-consistency-2021 High level notes.
**** All preferred emails lack external ids issues have been corrected. All group loops have been corrected.
**** Workaround is we can stop Gerrit, push to external ids directly, reindex accounts (and groups?), start gerrit, then clear accounts caches (and groups caches?)
**** Next steps
***** Review groups in review:~clarkb/gerrit_user_cleanups/notes.20210315 and determine if they can be safely cleaned up like previous groups.
***** https://review.opendev.org/c/opendev/system-config/+/780663 more user auditing improvements.
*** Configuration tuning
**** Using strong refs for jgit caches
**** Batch user groups and threads
* General topics
** Picking up steam on Puppet -> Ansible rewrites (clarkb 20210316)
*** Enable Xenial -> Bionic/Focal system upgrades
*** https://etherpad.opendev.org/p/infra-puppet-conversions-and-xenial-upgrades Start capturing TODO list here
*** Zuul service host updates in progress now. Mergers and executors done. Nodepool launchers in progress now.
*** Ianw working on kerberos server updates.
** Deploy a new refstack.openstack.org server (kopecmartin 20210316)
*** Ready for testing?
** PTG Planning (clarkb 20210316)
*** Next PTG April 19-23
*** Please let me know if you are interested so I can fill out the team survey (or not).
** review server upgrade (ianw 20210316)
*** Initial spec https://review.opendev.org/c/opendev/infra-specs/+/780478
* Open discussion
We will meet March 9, 2021 at 19:00 UTC in #opendev-meeting with this agenda:
== Agenda for next meeting ==
* Announcements
** Clarkb out March 23. Will need volunteer to run the meeting or we can skip it.
** DST change happens for those of us in North America this weekend. EU and others follow in a few weeks.
* Actions from last meeting
* Specs approval
* Priority Efforts (Standing meeting agenda items. Please expand if you have subtopics.)
** [http://specs.openstack.org/openstack-infra/infra-specs/specs/update-config-… Update Config Management]
*** topic:update-cfg-mgmt
*** Zuul as CD engine
** OpenDev
*** Gerrit account and group inconsistencies
**** https://etherpad.opendev.org/p/gerrit-user-consistency-2021 High level notes.
**** Workaround is we can stop Gerrit, push to external ids directly, reindex accounts (and groups?), start gerrit, then clear accounts caches (and groups caches?)
**** Next steps
***** Identify accounts that cannot be used because they have no valid method of login (no username, and no openids)
***** Identify accounts that are unlikely to be used anymore based on activity and more forcefully retire those to fix these errors. (We can always undo specific updates to these accounts if necessary)
***** Work with remaining accounts to figure out how to best resolve the account conflicts. This may take some time.
***** https://review.opendev.org/c/opendev/system-config/+/777846 Collecting scripting efforts here
***** Inactive accounts have been cleaned up.
*** Configuration tuning
**** Using strong refs for jgit caches
**** Batch user groups and threads
* General topics
** OpenAFS cluster status (clarkb 20210309)
*** Upgrading servers to Bionic then Focal next.
*** New third db server for proper quorum.
** Bup and Borg Backups (clarkb 20210309)
*** gitea sql db backup issues.
** Picking up steam on Puppet -> Ansible rewrites (clarkb 20210309)
*** Enable Xenial -> Bionic/Focal system upgrades
*** https://etherpad.opendev.org/p/infra-puppet-conversions-and-xenial-upgrades Start capturing TODO list here
*** Zuul service host updates in progress now. Mergers and executors largely done. Next up Nodepool launchers.
** Deploy a new refstack.openstack.org server (kopecmartin 20210309)
*** Ready for testing?
** Bridge disk space (clarkb 20210309)
*** This is related to stevedore caching entrypoints
*** We have upgraded stevedore and set config to prevent it from creating new cache files.
** PTG Planning (clarkb 20210309)
*** Next PTG April 19-23
*** Please let me know if you are interested so I can fill out the team survey (or not).
* Open discussion
As I observed that proposed changes can easily be ignored for months if the
original submitter did not manually added anyone or missed to do the
footwork of chasing cores on irc, I wonder if it would not be possible for
*some* projects to enable a feature to auto-add reviewers.
On the dark side of the world I seen the "codeowners
<https://docs.github.com/en/github/creating-cloning-and-archiving-repositori…>"
features being quite successful in assigning reviewers, as a simple file
can define the pool of potential reviewers. Based on how the repository is
configured it does randomly pick a limited number of candidates. Github
mentions in their release notes from 2017 that their inspiration for that
feature was the OWNERS file used by chromium team (gerrit users). I also
seen that Wikimedia experimented something
<https://phabricator.wikimedia.org/phame/live/1/post/139/gerrit_now_automati…>
in that area, apparently there is a wiki page where people can mark them as
available to be picked.
The watched project feature in Gerrit is useless for this purpose as it
does not randomly pick some of a pool of possible candidates. It may be
practical to use if there are projects with only 2-3 core reviewers.
There are two aspects I am looking to address, at least partially:
A) Improve random external contributors first-contribution experience -
right now, even if they propose a perfectly valid change, there is high
chance it will not get noticed. As you can imagine this lowers the chance
they would try again, or to become an active contributor.
B) Spread the review burden on cores and avoid "punishing" those that are
more active from being assaulted by review requests.
The current secret source for getting reviews on a project where you do not
know anyone involves looking at recent changes to spot people that did
reviews or at least have core powers and try to contact those. Even if this
works or not, it puts extra pressure on active people. That is why I would
see an automatic round-robin approach more appropriate.
As some may no longer be involved with the project, this could prove to be
an opportunity to revise the core list, or to gently remove yourself from
the list of cores.
C) How to deter people from adding reviewers before CI jobs report green?
I have no idea how to educate people not to add reviewers to changes that
are not yet green. I know there are valid cases where this is needed, but
likely is more like on less than one 1:5.
As no hard limit would work, maybe there is a way to display some kind of
message in the UI, advising user not to assign reviewers until CI reports
green. The same issue applies even to automatic reviewer assignment, which
should not happen right after a review is created. Ideally this should
happen when it passed CI, but it could also be ok if it would happen when
a review is moved from WIP to ready-for-review. I personally use a default
where any change I create is marked as WIP and this default can also be
changed at server level if we want.
--
/zbr
We will meet on March 2, 2021 at 19:00 UTC in #opendev-meeting with this agenda:
== Agenda for next meeting ==
* Announcements
* Actions from last meeting
* Specs approval
* Priority Efforts (Standing meeting agenda items. Please expand if you have subtopics.)
** [http://specs.openstack.org/openstack-infra/infra-specs/specs/update-config-… Update Config Management]
*** topic:update-cfg-mgmt
*** Zuul as CD engine
** OpenDev
*** Gerrit account and group inconsistencies
**** https://etherpad.opendev.org/p/gerrit-user-consistency-2021 High level notes.
**** We have 17 accounts with preferred email addresses that don't have a matching external id
**** Need to correct the ~642 external id issues before we can push updates to refs/meta/external-ids with Gerrit online.
**** Workaround is we can stop Gerrit, push to external ids directly, reindex accounts (and groups?), start gerrit, then clear accounts caches (and groups caches?)
**** Next steps
***** Identify accounts that are inactive and can be more forcefully retired. Retire these to fix those errors.
***** Identify accounts that are unlikely to be used anymore based on activity and more forcefully retire those to fix these errors. (We can always undo specific updates to these accounts if necessary)
***** Work with remaining accounts to figure out how to best resolve the account conflicts. This may take some time.
***** https://review.opendev.org/c/opendev/system-config/+/777846 Collecting scripting efforts here
*** Configuration tuning
**** Using strong refs for jgit caches
**** Batch user groups and threads
* General topics
** OpenAFS cluster status (clarkb 20210302)
*** Upgrading servers to Bionic then Focal next.
*** New third db server for proper quorum.
** Bup and Borg Backups (clarkb 20210302)
*** gitea sql db backup issues.
** Picking up steam on Puppet -> Ansible rewrites (clarkb 20210302)
*** Enable Xenial -> Bionic/Focal system upgrades
*** https://etherpad.opendev.org/p/infra-puppet-conversions-and-xenial-upgrades Start capturing TODO list here
*** Zuul service host updates in progress now. Mergers are done. Executors in progress.
** Deploy a new refstack.openstack.org server (kopecmartin 20210302)
*** Ready for testing?
** Bridge disk space (clarkb 20210302)
*** This appears at least partially related to ansible and python caching. Should we just clear those caches then profile them?
* Open discussion