On 2019-09-02 21:13:58 +0200 (+0200), Andreas Jaeger wrote:

On 30/08/2019 00.00, Vitaliy Lotorev wrote:

...

Starting with at least v2.15 Gerrit is able to differentiate bot comments and hide them using 'Show comments' trigger on web UI. This is achived either using tagged comments or robot comments.

A while ago I filed an issue about Zuul not using these technics[1] (ticket has links for Gerrit docs with tagged and robot comments). This results that Zuul comments are not hiddable in Gerrit.

Yes, that is intended behaviour, see https://review.opendev.org/#/c/655783/

I think this was more about making Zuul able to use new features in Gerrit, nothing to do with OpenDev's Zuul deployment and hideci.js overlay for Gerrit.

Vitaliy Lotorev lotorev@gmail.com writes:

Hi,

Starting with at least v2.15 Gerrit is able to differentiate bot comments and hide them using 'Show comments' trigger on web UI. This is achived either using tagged comments or robot comments.

A while ago I filed an issue about Zuul not using these technics [1] (ticket has links for Gerrit docs with tagged and robot comments). This results that Zuul comments are not hiddable in Gerrit.

AFAIK, sending tagged comments via SSH to Gerrit is easy (one-line of code at [2]).

I could try providing a patch for tagged comments.

What Zuul maintainers think about adding support for bot comments?

Should not be sending tagged comments done only if Gerrit version >= 2.15?

[1] https://storyboard.openstack.org/#!/story/2005661 [2] https://opendev.org/zuul/zuul/src/branch/master/zuul/driver/gerrit/gerritcon...

Yes, I think that both tagged and robot comments would be a great addition, and I think that checking the Gerrit version would be a good idea (since we have some users who haven't upgraded to 2.15 yet).

Note also that Zuul supports the REST api as well, so you may want to modify the function below the place you cited as well in order to support both.

Thanks!

-Jim