sebastien.boeuf at intel.com
Fri Feb 8 19:27:13 UTC 2019
I agree Andreea, and I would also suggest that once we agreed on the creation of a crate, and once we agreed on the global code coming from the private repo, we still need to create a clean repo under rust-vmm and start from scratch with proper PRs that can be reviewed.
Starting with already something in the repo sounds wrong to me. The most intensive code reviews should really happen on the rust-vmm repos.
Does that make sense?
On Fri, 2019-02-08 at 11:58 +0000, Florescu, Andreea wrote:
For future crates I would suggest we do not create repositories directly in the rust-vmm organization and use the review process we discussed a while back:
- Create a repository on the personal profile
- Request reviews for the repository using the issue template for reviews
This process is also described in the community readme: https://github.com/rust-vmm/community
Regarding the review, I might be able to look at the changes somewhere after Wednesday next week.
From: Liu Jiang <liuj97 at gmail.com>
Sent: Friday, February 8, 2019 12:17 PM
To: rust-vmm ML; Florescu, Andreea; Samuel Ortiz; Boeuf, Sebastien; Iordache, Alexandra; Dylan Reid; Dr. David Alan Gilbert
Subject: [Rust-VMM] RFC:
As we have discussed during the meeting, I have created a memory-model repository under rust-vmm project and posted the initial version at https://github.com/rust-vmm/memory-model .
The initial version tries to merge current code from the upstream crosvm and firecracker projects. And the most sensitive user visible change is changing from u64 to usize for memory related data fields.
So please help to comment on whether this is the right way to go, and next step plan is:
1) import endian.rs<http://endian.rs/> from crosvm
2) add address space abstraction for virtual machine
Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Rust-vmm