[Rust-VMM] Adding ARM support to kvm-ioctls
dgreid at chromium.org
Mon Mar 25 22:48:10 UTC 2019
On Mon, Mar 25, 2019 at 9:06 AM Florescu, Andreea <fandree at amazon.com> wrote:
> I sent an email to Zach as well a couple of day ago.
> Let me just copy paste parts of the email here in case somebody else from CrosVM wants to take a look at the PR. Hopefully this will help in the review process.
> The kvm-ioctls crate doesn't yet have all the functionality that you need in CrosVM, but I was planning on adding that in a following PR as this one is already quite large already.
> Some notable changes from the CrosVM kvm crate:
> - Kvm, Vcpu and Vm do not have a public constructor anymore. The Kvm class implements a create_vm method and the Vm class implements a create_vcpu method. I did this change so we can have the same separation of ioctls as found in the KVM implementation.
> - Each ioctl group lies in a different module, but that should not have any impact on how you use it because the ioctls are exported with pub use iocts::system::* and so on.
> - I use the io::Error instead of errno.rs. One of the reasons is the one we discussed about in the call (pretty printing errors). The other reason is that the vmm-sys-utils crate is not available for import just yet.
> - The crate does not depend on EventFd and uses a RawFd instead.
Sorry that we've been less than responsive. It's a busy time of year
for Chrome OS and allocating resources to these reviews is
Generally, departures similar to those listed here are acceptable. As
long as the new crates avoid external dependencies such as nix, rayon,
etc. it won't make crosvm integration harder.
Don't let a lack of review from crosvm block progress on the initial
crates. It's more important to get something landed than for the first
pass to be perfect. There will be a few iterations before we have both
firecracker and crosvm rebased on top of the new crates. Hopefully we
retain flexibility before we push these interfaces to a 1.0 release.
> I don't know if I missed something else.
> Let me know if you have any questions.
> From: Boeuf, Sebastien <sebastien.boeuf at intel.com>
> Sent: Monday, March 25, 2019 3:57 PM
> To: Ortiz, Samuel; Florescu, Andreea
> Cc: Popa, Diana-Maria; rust-vmm at lists.opendev.org
> Subject: Re: [Rust-VMM] Adding ARM support to kvm-ioctls
> On Mon, 2019-03-25 at 15:45 +0100, Samuel Ortiz wrote:
> > Hi Andreea,
> > On Mon, Mar 25, 2019 at 02:38:12PM +0000, Florescu, Andreea wrote:
> > > Hey everyone,
> > >
> > >
> > > I am working on adding an initial implementation for kvm-ioctls, PR
> > > here .
> > >
> > > In the meantime, Diana (in cc) is working for adding ARM support
> > > for Firecracker and she would be interested in adding the required
> > > ARM ioctls directly to the kvm-ioctls crate.
> > >
> > >
> > > Does anybody have major concerns regarding the first version of the
> > > kvm-ioctls crate? I would like to get it merged to unblock the work
> > > on ARM.
> > >
> > It looks good to me.
> Yes same here, but I would really want to make sure Zach approves it
> too, as we want to see crosvm reusing this crate.
> > Cheers,
> > Samuel.
> > ---------------------------------------------------------------------
> > Intel Corporation SAS (French simplified joint stock company)
> > Registered headquarters: "Les Montalets"- 2, rue de Paris,
> > 92196 Meudon Cedex, France
> > Registration Number: 302 456 199 R.C.S. NANTERRE
> > Capital: 4,572,000 Euros
> > This e-mail and any attachments may contain confidential material for
> > the sole use of the intended recipient(s). Any review or distribution
> > by others is strictly prohibited. If you are not the intended
> > recipient, please contact the sender and delete all copies.
> > _______________________________________________
> > Rust-vmm mailing list
> > Rust-vmm at lists.opendev.org
> > http://lists.opendev.org/cgi-bin/mailman/listinfo/rust-vmm
> Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.
> Rust-vmm mailing list
> Rust-vmm at lists.opendev.org
More information about the Rust-vmm