Starlingx/API-Ref review

[Camp, MaryX]

Hi Clark, 
I submitted a new review, it was merged and the Zuul promote worked as expected.   https://review.opendev.org/#/c/726922/ 
We still don't know why it failed before, but thanks a bunch for the suggestion on how to kick-start it again.

-Mary C. 

-----Original Message-----
From: Clark Boylan <cboylan at sapwetik.org> 
Sent: Friday, May 8, 2020 7:51 PM
To: Liu, Tao <Tao.Liu at windriver.com>; service-discuss at lists.opendev.org
Cc: Jeremy Stanley <fungi at yuggoth.org>; Camp, MaryX <maryx.camp at intel.com>
Subject: Re: Starlingx/API-Ref review

On Fri, May 8, 2020, at 3:41 PM, Liu, Tao wrote:
> Thanks Clark for looking into this. 
> 
> Do you know why StarlingX API Documentation was not updated: 
> https://docs.starlingx.io/api-ref/distcloud/? Although, the review has 
> been merged.

Looks like the api-ref job hasn't run recently on that repo: https://zuul.openstack.org/builds?project=starlingx%2Fdistcloud&pipeline=promote. Looking at the configuration for that job I've found: https://opendev.org/starlingx/zuul-jobs/src/branch/master/zuul.d/project-templates.yaml#L20-L23 which shows that the job will only run if these files are updated: https://opendev.org/starlingx/zuul-jobs/src/branch/master/zuul.d/project-templates.yaml#L8-L15

I think the other changes that have merged don't update those files. The easiest way to address this is likely to merge a change to one of those files. Then if that newer change fails to run properly we can debug that failure.

> 
> Tao
> 
> -----Original Message-----
> From: Clark Boylan [mailto:cboylan at sapwetik.org]
> Sent: Friday, May 8, 2020 5:50 PM
> To: Liu, Tao; service-discuss at lists.opendev.org
> Cc: Jeremy Stanley; Camp, MaryX
> Subject: Re: Starlingx/API-Ref review
> 
> On Fri, May 8, 2020, at 12:07 PM, Liu, Tao wrote:
> >  
> > Hi OpenDev support team,
> > 
> > 
> > The review below stuck at Build failed (promote pipeline). Can you 
> > please check the status and let me know how to fix this issue?
> 
> The promote pipeline only runs after a change has merged. Rechecking a 
> change will not rerun the promote jobs. Typically the best way to 
> handle promote failures is to fix the cause of the failure, then when 
> the fix merges this will run the promote jobs for the fix change 
> updating your artifacts that way. If the fix is made to a different 
> project then we can trigger the promote jobs separately.
> 
> In this case changes to starlingx/distcloud have landed since those 
> failures and promote jobs have run successfully for them. I think this 
> means we don't need to do anything for this particular case.
> 
> > 
> > https://review.opendev.org/#/c/720589/
> > 
> > 
> > 
> > Thanks
> 
>