[Rust-VMM] Project gate keeping

Paolo Bonzini pbonzini at redhat.com
Fri Jun 7 15:28:55 UTC 2019

On 07/06/19 10:23, Samuel Ortiz wrote:
> - Have a team of 8-10 rust-vmm gatekeepers. 2 randomly selected
>   gatekeepers will be automatically assigned to any incoming PR.

Would gatekeepers be automatically given access to all rustvmm repos?
Is that possible from the GitHub UI or do you have to do that manually?

> - Any gate keeper is free to assign someone else from the gate keeper
>   team if she/he does not have the badwidth/knowledge to review the PR.
> - Encourage CODEOWNERS[1] file additions. Not all repos may need such
>   ownership so I don't think this should be mandatory.
> - Any PR will be mergeable when any of the below conditions are met:
>   * When a repo has a CODEOWNERS file, 1 code owner and 1 gate keeper
>     approved it.
>   * On CODEOWNERS-less repos, 2 gate keepers approved it.

I think even that is too much; I don't see a reason to overload
gatekeepers with the task of closing PRs.  My proposal is:

- up to 2 randomly selected code owners, or gatekeepers if there are <2
code owners will be automatically assigned to any incoming PR

- as far as the GitHub UI is concerned, just one approving review from a
code owner or gatekeeper is enough to merge

- code owners and gatekeepers however are warmly encouraged to wait for
a review from a second person for anything except obvious bugfixes, or
to wait for a second code owner or gatekeeper to actually do the merge
and close the PR.

> - Initial PRs for empty crates could be handled differently and
>   informally require more approvals from different people.



More information about the Rust-vmm mailing list