[Rust-VMM] Project gate keeping

Florescu, Andreea fandree at amazon.com
Mon Jun 10 12:52:20 UTC 2019

Hey Paolo,

Two reviews from code owners sounds good to me as well.
We should make sure that repositories being crated have code owners.

From: Paolo Bonzini <pbonzini at redhat.com>
Sent: Monday, June 10, 2019 2:25 PM
To: Florescu, Andreea; Samuel Ortiz; rust-vmm ML
Subject: Re: [Rust-VMM] Project gate keeping

On 10/06/19 10:23, Florescu, Andreea wrote:
> I prefer having two approvals either from code owners or gatekeepers
> when there are no code owners. Merging a PR with only one review
> should be an exception from my point of view. More often than not 2
> different people looking at the code will find different bugs or
> other issues (lack of tests, documentation, others?).
> GitHub allows administrators to merge PRs even though there are not 2
> reviews, so we can merge PRs with one review if needed, but I think
> we should have 2 reviewers as the rule.

My fear is that the second review will, more often than not, be a
"drive-by" review where X gave a positive review so Y just clicks
approve and merge---especially if the second review has to be from a
gatekeeper that may not be that much in touch with the code.

So I have no particular qualms with requiring two reviews, but I'd
rather not require a separate gatekeeper "super-review" and instead
allow 2 code owner reviews when there are 2 code owners.


Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.

More information about the Rust-vmm mailing list