[Rust-VMM] Project gate keeping

Samuel Ortiz samuel.ortiz at intel.com
Tue Jun 11 05:07:37 UTC 2019

On Mon, Jun 10, 2019 at 01:25:07PM +0200, Paolo Bonzini wrote:
> On 10/06/19 10:23, Florescu, Andreea wrote:
> > I prefer having two approvals either from code owners or gatekeepers
> > when there are no code owners. Merging a PR with only one review
> > should be an exception from my point of view. More often than not 2
> > different people looking at the code will find different bugs or
> > other issues (lack of tests, documentation, others?).
> > 
> > GitHub allows administrators to merge PRs even though there are not 2
> > reviews, so we can merge PRs with one review if needed, but I think
> > we should have 2 reviewers as the rule.
> My fear is that the second review will, more often than not, be a
> "drive-by" review where X gave a positive review so Y just clicks
> approve and merge---especially if the second review has to be from a
> gatekeeper that may not be that much in touch with the code.
> So I have no particular qualms with requiring two reviews, but I'd
> rather not require a separate gatekeeper "super-review" and instead
> allow 2 code owner reviews when there are 2 code owners.
That sounds reasonable to me. 2 code owners reviews when there are at
least 2 of them, otherwise 1+1 or 0+2.
It's also good to have gate keepers to be able to help with the review
if for some reason one of the code owners is MIA.

Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris, 
92196 Meudon Cedex, France
Registration Number:  302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

More information about the Rust-vmm mailing list