[Rust-VMM] Project gate keeping
samuel.ortiz at intel.com
Mon Jun 10 08:34:49 UTC 2019
On Fri, Jun 07, 2019 at 05:28:55PM +0200, Paolo Bonzini wrote:
> On 07/06/19 10:23, Samuel Ortiz wrote:
> > - Have a team of 8-10 rust-vmm gatekeepers. 2 randomly selected
> > gatekeepers will be automatically assigned to any incoming PR.
> Would gatekeepers be automatically given access to all rustvmm repos?
> Is that possible from the GitHub UI or do you have to do that manually?
AFAIK with github you create a rust-vmm gatekeepers team, and then you
have to manually add this team to each new repo. Much less tedious than
added folks one by one.
> > - Any gate keeper is free to assign someone else from the gate keeper
> > team if she/he does not have the badwidth/knowledge to review the PR.
> > - Encourage CODEOWNERS file additions. Not all repos may need such
> > ownership so I don't think this should be mandatory.
> > - Any PR will be mergeable when any of the below conditions are met:
> > * When a repo has a CODEOWNERS file, 1 code owner and 1 gate keeper
> > approved it.
> > * On CODEOWNERS-less repos, 2 gate keepers approved it.
> I think even that is too much; I don't see a reason to overload
> gatekeepers with the task of closing PRs. My proposal is:
> - up to 2 randomly selected code owners, or gatekeepers if there are <2
> code owners will be automatically assigned to any incoming PR
> - as far as the GitHub UI is concerned, just one approving review from a
> code owner or gatekeeper is enough to merge
> - code owners and gatekeepers however are warmly encouraged to wait for
> a review from a second person for anything except obvious bugfixes,
I'd rather have a requirement for a second approval. The "warmly
encouraged" part of that statement is a little too vague imho.
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris,
92196 Meudon Cedex, France
Registration Number: 302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
More information about the Rust-vmm