[Rust-VMM] Project gate keeping
zachr at google.com
Wed Jun 12 15:09:21 UTC 2019
On Fri, Jun 7, 2019 at 1:24 AM Samuel Ortiz <samuel.ortiz at intel.com> wrote:
> As discussed during last week's call, I'd like to propose a light
> process for PR reviews and gate keeping.
> At the moment, when a PR lands in any of the existing crates, no one
> gets assigned to review it and we're asking for 2 review approvals
> before merging it. Those approvals should come from members of the
> crate's "team", and we need to arbitrarily build those teams on the
> fly based on the crate activity and contributions.
> As the number of incoming PRs is increasing, I feel we're starting to
> see some limitations with the above described model. While many PRs get
> actively reviewed, others slightly less. Also, pinging people for
> reviews and approvals is handled manually at the moment.
> In order to improve that situation, here is my proposal:
> - Have a team of 8-10 rust-vmm gatekeepers. 2 randomly selected
> gatekeepers will be automatically assigned to any incoming PR.
> - Any gate keeper is free to assign someone else from the gate keeper
> team if she/he does not have the badwidth/knowledge to review the PR.
> - Encourage CODEOWNERS file additions. Not all repos may need such
> ownership so I don't think this should be mandatory.
> - Any PR will be mergeable when any of the below conditions are met:
> * When a repo has a CODEOWNERS file, 1 code owner and 1 gate keeper
> approved it.
> * On CODEOWNERS-less repos, 2 gate keepers approved it.
> - Initial PRs for empty crates could be handled differently and
> informally require more approvals from different people.
> I guess the natural question coming next is who should be part of this
> gate keeper team. rust-vmm being almost 6 months old, I think we now
> have a good idea of who are the most active contributors to the
> project. And I think it's logical to build this initial gate keepers
> team from those initial active contributors:
> Andreea Florescu @andreeaflorescu
> Alexandru Agache @alexandruag
> Alexandra Iordache @aghecenco
> Jiang Liu @jiangliu
> Paolo Bonzini @bonzini
> Zach Reizner @zachreizner
> Jenny Mankin @jennymankin
> Sebastien Boeuf @sboeuf
> Rob Bradford @rbradford
> Samuel Ortiz @sameo
I agree to serve as a gatekeeper and the overall plan sounds good. Thanks.
> Comments, disagreements, additions, etc are all very welcome.
>  https://help.github.com/en/articles/about-code-owners
> Intel Corporation SAS (French simplified joint stock company)
> Registered headquarters: "Les Montalets"- 2, rue de Paris,
> 92196 Meudon Cedex, France
> Registration Number: 302 456 199 R.C.S. NANTERRE
> Capital: 4,572,000 Euros
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
> Rust-vmm mailing list
> Rust-vmm at lists.opendev.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Rust-vmm